diff --git a/completions.go b/completions.go index ac25a9d..9ecd56a 100644 --- a/completions.go +++ b/completions.go @@ -228,7 +228,17 @@ func (c *Command) getCompletions(args []string) (*Command, []string, ShellCompDi if c.Root().TraverseChildren { finalCmd, finalArgs, err = c.Root().Traverse(trimmedArgs) } else { - finalCmd, finalArgs, err = c.Root().Find(trimmedArgs) + // For Root commands that don't specify any value for their Args fields, when we call + // Find(), if those Root commands don't have any sub-commands, they will accept arguments. + // However, because we have added the __complete sub-command in the current code path, the + // call to Find() -> legacyArgs() will return an error if there are any arguments. + // To avoid this, we first remove the __complete command to get back to having no sub-commands. + rootCmd := c.Root() + if len(rootCmd.Commands()) == 1 { + rootCmd.RemoveCommand(c) + } + + finalCmd, finalArgs, err = rootCmd.Find(trimmedArgs) } if err != nil { // Unable to find the real command. E.g., someInvalidCmd diff --git a/completions_test.go b/completions_test.go index 2d6c11d..6a62f0c 100644 --- a/completions_test.go +++ b/completions_test.go @@ -2619,3 +2619,48 @@ func TestCompleteWithDisableFlagParsing(t *testing.T) { t.Errorf("expected: %q, got: %q", expected, output) } } + +func TestCompleteWithRootAndLegacyArgs(t *testing.T) { + // Test a lonely root command which uses legacyArgs(). In such a case, the root + // command should accept any number of arguments and completion should behave accordingly. + rootCmd := &Command{ + Use: "root", + Args: nil, // Args must be nil to trigger the legacyArgs() function + Run: emptyRun, + ValidArgsFunction: func(cmd *Command, args []string, toComplete string) ([]string, ShellCompDirective) { + return []string{"arg1", "arg2"}, ShellCompDirectiveNoFileComp + }, + } + + // Make sure the first arg is completed + output, err := executeCommand(rootCmd, ShellCompNoDescRequestCmd, "") + if err != nil { + t.Errorf("Unexpected error: %v", err) + } + + expected := strings.Join([]string{ + "arg1", + "arg2", + ":4", + "Completion ended with directive: ShellCompDirectiveNoFileComp", ""}, "\n") + + if output != expected { + t.Errorf("expected: %q, got: %q", expected, output) + } + + // Make sure the completion of arguments continues + output, err = executeCommand(rootCmd, ShellCompNoDescRequestCmd, "arg1", "") + if err != nil { + t.Errorf("Unexpected error: %v", err) + } + + expected = strings.Join([]string{ + "arg1", + "arg2", + ":4", + "Completion ended with directive: ShellCompDirectiveNoFileComp", ""}, "\n") + + if output != expected { + t.Errorf("expected: %q, got: %q", expected, output) + } +}