vinchent/cobra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing golint warnings

Browse Source 
* Moving final return outside of if-else
* Removing type declarations that Go can infer from values
* Cleaning up some existing comments
* Changing snake_case variables to camelCase
This commit is contained in:
Ian Walter
2016-03-31 09:53:34 -04:00
parent c678ff029e
commit a0bd6c17b3
8 changed files with 40 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cobra_test.go
View File

@ -454,10 +454,10 @@ func TestGrandChildSameName(t *testing.T) {
func TestUsage(t *testing.T) {
x := fullSetupTest("help")
checkResultContains(t, x, cmdRootWithRun.Use + " [flags]")
checkResultContains(t, x, cmdRootWithRun.Use+" [flags]")
x = fullSetupTest("help customflags")
checkResultContains(t, x, cmdCustomFlags.Use)
checkResultOmits(t, x, cmdCustomFlags.Use + " [flags]")
checkResultOmits(t, x, cmdCustomFlags.Use+" [flags]")
}
func TestFlagLong(t *testing.T) {
@ -752,7 +752,7 @@ func TestVisitParents(t *testing.T) {
}
func TestRunnableRootCommandNilInput(t *testing.T) {
empty_arg := make([]string, 0)
var emptyArg []string
c := initializeWithRootCmd()
buf := new(bytes.Buffer)
@ -760,7 +760,7 @@ func TestRunnableRootCommandNilInput(t *testing.T) {
c.SetOutput(buf)
cmdEcho.AddCommand(cmdTimes)
c.AddCommand(cmdPrint, cmdEcho)
c.SetArgs(empty_arg)
c.SetArgs(emptyArg)
err := c.Execute()
if err != nil {
@ -863,7 +863,7 @@ func TestFlagAccess(t *testing.T) {
}
func TestNoNRunnableRootCommandNilInput(t *testing.T) {
args := make([]string, 0)
var args []string
c := initialize()
buf := new(bytes.Buffer)