vinchent/cobra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix test build breakage with go1.11 (#712)

Browse Source 
As discussed in golang/go#26109, vet typecheck is enabled
in go1.11 and the command_test.go can't be compiled any
more with go1.11 due to the unread variables in the
command_test.go.

Instead of removing the unused variables, this CL reads the
variables and compares the values against the current
behavior so when the related issue is fixed, this test can
be updated accordingly.
This commit is contained in:
Hyang-Ah Hana Kim 2018-06-29 11:25:35 -04:00 committed by Eric Paris
parent 1e58aa3361
commit a114f312e0
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
command_test.go
View File

@ -1164,12 +1164,13 @@ func TestPersistentHooks(t *testing.T) {
t.Errorf("Unexpected error: %v", err) t.Errorf("Unexpected error: %v", err)
} }
// TODO: This test fails, but should not. // TODO: currently PersistenPreRun* defined in parent does not
// Related to https://github.com/spf13/cobra/issues/252. // run if the matchin child subcommand has PersistenPreRun.
// // If the behavior changes (https://github.com/spf13/cobra/issues/252)
// if parentPersPreArgs != "one two" { // this test must be fixed.
// t.Errorf("Expected parentPersPreArgs %q, got %q", "one two", parentPersPreArgs) if parentPersPreArgs != "" {
// } t.Errorf("Expected blank parentPersPreArgs, got %q", parentPersPreArgs)
}
if parentPreArgs != "" { if parentPreArgs != "" {
t.Errorf("Expected blank parentPreArgs, got %q", parentPreArgs) t.Errorf("Expected blank parentPreArgs, got %q", parentPreArgs)
} }
@ -1179,12 +1180,13 @@ func TestPersistentHooks(t *testing.T) {
if parentPostArgs != "" { if parentPostArgs != "" {
t.Errorf("Expected blank parentPostArgs, got %q", parentPostArgs) t.Errorf("Expected blank parentPostArgs, got %q", parentPostArgs)
} }
// TODO: This test fails, but should not. // TODO: currently PersistenPostRun* defined in parent does not
// Related to https://github.com/spf13/cobra/issues/252. // run if the matchin child subcommand has PersistenPostRun.
// // If the behavior changes (https://github.com/spf13/cobra/issues/252)
// if parentPersPostArgs != "one two" { // this test must be fixed.
// t.Errorf("Expected parentPersPostArgs %q, got %q", "one two", parentPersPostArgs) if parentPersPostArgs != "" {
// } t.Errorf("Expected blank parentPersPostArgs, got %q", parentPersPostArgs)
}
if childPersPreArgs != "one two" { if childPersPreArgs != "one two" {
t.Errorf("Expected childPersPreArgs %q, got %q", "one two", childPersPreArgs) t.Errorf("Expected childPersPreArgs %q, got %q", "one two", childPersPreArgs)