From 0cb7c44abc8280411ee5ab3cc67ff63aaee2bf3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E7=94=B0=E6=AC=A7?= <thinkerou@gmail.com>
Date: Thu, 28 Sep 2017 22:58:57 -0500
Subject: [PATCH] Print warning log when user create one engine using
 gin.Default in debug mode (#1121)

* empty string check

* add log when use Default

* fix unit test error

* fix unit test error
---
 debug.go      |  6 ++++++
 debug_test.go | 18 ++++++++++++++++++
 gin.go        |  1 +
 3 files changed, 25 insertions(+)

diff --git a/debug.go b/debug.go
index b31ca68..449291e 100644
--- a/debug.go
+++ b/debug.go
@@ -46,6 +46,12 @@ func debugPrint(format string, values ...interface{}) {
 	}
 }
 
+func debugPrintWARNINGDefault() {
+	debugPrint(`[WARNING] Creating an Engine instance with the Logger and Recovery middleware already attached.
+
+`)
+}
+
 func debugPrintWARNINGNew() {
 	debugPrint(`[WARNING] Running in "debug" mode. Switch to "release" mode in production.
  - using env:	export GIN_MODE=release
diff --git a/debug_test.go b/debug_test.go
index 366d461..dfd54c8 100644
--- a/debug_test.go
+++ b/debug_test.go
@@ -86,6 +86,24 @@ func TestDebugPrintWARNINGSetHTMLTemplate(t *testing.T) {
 	assert.Equal(t, "[GIN-debug] [WARNING] Since SetHTMLTemplate() is NOT thread-safe. It should only be called\nat initialization. ie. before any route is registered or the router is listening in a socket:\n\n\trouter := gin.Default()\n\trouter.SetHTMLTemplate(template) // << good place\n\n", w.String())
 }
 
+func TestDebugPrintWARNINGDefault(t *testing.T) {
+	var w bytes.Buffer
+	setup(&w)
+	defer teardown()
+
+	debugPrintWARNINGDefault()
+	assert.Equal(t, "[GIN-debug] [WARNING] Creating an Engine instance with the Logger and Recovery middleware already attached.\n\n", w.String())
+}
+
+func TestDebugPrintWARNINGNew(t *testing.T) {
+	var w bytes.Buffer
+	setup(&w)
+	defer teardown()
+
+	debugPrintWARNINGNew()
+	assert.Equal(t, "[GIN-debug] [WARNING] Running in \"debug\" mode. Switch to \"release\" mode in production.\n - using env:\texport GIN_MODE=release\n - using code:\tgin.SetMode(gin.ReleaseMode)\n\n", w.String())
+}
+
 func setup(w io.Writer) {
 	SetMode(DebugMode)
 	log.SetOutput(w)
diff --git a/gin.go b/gin.go
index 9466e07..8cfb1f1 100644
--- a/gin.go
+++ b/gin.go
@@ -144,6 +144,7 @@ func New() *Engine {
 
 // Default returns an Engine instance with the Logger and Recovery middleware already attached.
 func Default() *Engine {
+	debugPrintWARNINGDefault()
 	engine := New()
 	engine.Use(Logger(), Recovery())
 	return engine