vinchent/gin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #755 from gin-gonic/755-app-engine-client-ip

Browse Source 
Fix #723
This commit is contained in:
Bo-Yi Wu
2016-12-06 08:14:11 -06:00
committed by GitHub
parent 98af44604c 7e58c80a7c
commit 764e138e32
4 changed files with 30 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
context_test.go
View File

@ -684,6 +684,7 @@ func TestContextClientIP(t *testing.T) {
c.Request.Header.Set("X-Real-IP", " 10.10.10.10 ")
c.Request.Header.Set("X-Forwarded-For", " 20.20.20.20, 30.30.30.30")
c.Request.Header.Set("X-Appengine-Remote-Addr", "50.50.50.50")
c.Request.RemoteAddr = " 40.40.40.40:42123 "
assert.Equal(t, c.ClientIP(), "10.10.10.10")
@ -695,7 +696,15 @@ func TestContextClientIP(t *testing.T) {
assert.Equal(t, c.ClientIP(), "30.30.30.30")
c.Request.Header.Del("X-Forwarded-For")
c.engine.AppEngine = true
assert.Equal(t, c.ClientIP(), "50.50.50.50")
c.Request.Header.Del("X-Appengine-Remote-Addr")
assert.Equal(t, c.ClientIP(), "40.40.40.40")
// no port
c.Request.RemoteAddr = "50.50.50.50"
assert.Equal(t, c.ClientIP(), "")
}
func TestContextContentType(t *testing.T) {