vinchent/gin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes "http: multiple response.WriteHeader calls" in 404 [Issue #29]

Browse Source
This commit is contained in:
Manu Mtz-Almeida
2014-07-04 00:12:35 +02:00
parent 00413032bb
commit e1781e2db1
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gin.go
View File

@ -129,13 +129,11 @@ func (engine *Engine) CacheStress() float32 {
func (engine *Engine) handle404(w http.ResponseWriter, req *http.Request) { func (engine *Engine) handle404(w http.ResponseWriter, req *http.Request) {
handlers := engine.combineHandlers(engine.handlers404) handlers := engine.combineHandlers(engine.handlers404)
c := engine.createContext(w, req, nil, handlers) c := engine.createContext(w, req, nil, handlers)
if engine.handlers404 == nil { c.Writer.setStatus(404)
http.NotFound(c.Writer, c.Req)
} else {
c.Writer.WriteHeader(404)
}
c.Next() c.Next()
if !c.Writer.Written() {
c.String(404, "404 page not found")
}
engine.reuseContext(c) engine.reuseContext(c)
} }