ad53619b15
Fixes #1331 HTTP logging leaks sensitive request information. This PR removes HTTP request logging during panics.
75 lines
1.9 KiB
Go
75 lines
1.9 KiB
Go
// Copyright 2014 Manu Martinez-Almeida. All rights reserved.
|
|
// Use of this source code is governed by a MIT style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package gin
|
|
|
|
import (
|
|
"bytes"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// TestPanicInHandler assert that panic has been recovered.
|
|
func TestPanicInHandler(t *testing.T) {
|
|
buffer := new(bytes.Buffer)
|
|
router := New()
|
|
router.Use(RecoveryWithWriter(buffer))
|
|
router.GET("/recovery", func(_ *Context) {
|
|
panic("Oupps, Houston, we have a problem")
|
|
})
|
|
// RUN
|
|
w := performRequest(router, "GET", "/recovery")
|
|
// TEST
|
|
assert.Equal(t, http.StatusInternalServerError, w.Code)
|
|
assert.Contains(t, buffer.String(), "panic recovered")
|
|
assert.Contains(t, buffer.String(), "Oupps, Houston, we have a problem")
|
|
assert.Contains(t, buffer.String(), "TestPanicInHandler")
|
|
assert.NotContains(t, buffer.String(), "GET /recovery")
|
|
|
|
// Debug mode prints the request
|
|
SetMode(DebugMode)
|
|
// RUN
|
|
w = performRequest(router, "GET", "/recovery")
|
|
// TEST
|
|
assert.Equal(t, http.StatusInternalServerError, w.Code)
|
|
assert.Contains(t, buffer.String(), "GET /recovery")
|
|
|
|
}
|
|
|
|
// TestPanicWithAbort assert that panic has been recovered even if context.Abort was used.
|
|
func TestPanicWithAbort(t *testing.T) {
|
|
router := New()
|
|
router.Use(RecoveryWithWriter(nil))
|
|
router.GET("/recovery", func(c *Context) {
|
|
c.AbortWithStatus(http.StatusBadRequest)
|
|
panic("Oupps, Houston, we have a problem")
|
|
})
|
|
// RUN
|
|
w := performRequest(router, "GET", "/recovery")
|
|
// TEST
|
|
assert.Equal(t, http.StatusBadRequest, w.Code)
|
|
}
|
|
|
|
func TestSource(t *testing.T) {
|
|
bs := source(nil, 0)
|
|
assert.Equal(t, []byte("???"), bs)
|
|
|
|
in := [][]byte{
|
|
[]byte("Hello world."),
|
|
[]byte("Hi, gin.."),
|
|
}
|
|
bs = source(in, 10)
|
|
assert.Equal(t, []byte("???"), bs)
|
|
|
|
bs = source(in, 1)
|
|
assert.Equal(t, []byte("Hello world."), bs)
|
|
}
|
|
|
|
func TestFunction(t *testing.T) {
|
|
bs := function(1)
|
|
assert.Equal(t, []byte("???"), bs)
|
|
}
|