26c3f42095
* feat(binding): Add support for custom validation tags * docs: Add example for custom validation tag * test(binding): Add test for registering custom validation
235 lines
5.6 KiB
Go
235 lines
5.6 KiB
Go
// Copyright 2014 Manu Martinez-Almeida. All rights reserved.
|
|
// Use of this source code is governed by a MIT style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package binding
|
|
|
|
import (
|
|
"bytes"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
validator "gopkg.in/go-playground/validator.v8"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type testInterface interface {
|
|
String() string
|
|
}
|
|
|
|
type substructNoValidation struct {
|
|
IString string
|
|
IInt int
|
|
}
|
|
|
|
type mapNoValidationSub map[string]substructNoValidation
|
|
|
|
type structNoValidationValues struct {
|
|
substructNoValidation
|
|
|
|
Boolean bool
|
|
|
|
Uinteger uint
|
|
Integer int
|
|
Integer8 int8
|
|
Integer16 int16
|
|
Integer32 int32
|
|
Integer64 int64
|
|
Uinteger8 uint8
|
|
Uinteger16 uint16
|
|
Uinteger32 uint32
|
|
Uinteger64 uint64
|
|
|
|
Float32 float32
|
|
Float64 float64
|
|
|
|
String string
|
|
|
|
Date time.Time
|
|
|
|
Struct substructNoValidation
|
|
InlinedStruct struct {
|
|
String []string
|
|
Integer int
|
|
}
|
|
|
|
IntSlice []int
|
|
IntPointerSlice []*int
|
|
StructPointerSlice []*substructNoValidation
|
|
StructSlice []substructNoValidation
|
|
InterfaceSlice []testInterface
|
|
|
|
UniversalInterface interface{}
|
|
CustomInterface testInterface
|
|
|
|
FloatMap map[string]float32
|
|
StructMap mapNoValidationSub
|
|
}
|
|
|
|
func createNoValidationValues() structNoValidationValues {
|
|
integer := 1
|
|
s := structNoValidationValues{
|
|
Boolean: true,
|
|
Uinteger: 1 << 29,
|
|
Integer: -10000,
|
|
Integer8: 120,
|
|
Integer16: -20000,
|
|
Integer32: 1 << 29,
|
|
Integer64: 1 << 61,
|
|
Uinteger8: 250,
|
|
Uinteger16: 50000,
|
|
Uinteger32: 1 << 31,
|
|
Uinteger64: 1 << 62,
|
|
Float32: 123.456,
|
|
Float64: 123.456789,
|
|
String: "text",
|
|
Date: time.Time{},
|
|
CustomInterface: &bytes.Buffer{},
|
|
Struct: substructNoValidation{},
|
|
IntSlice: []int{-3, -2, 1, 0, 1, 2, 3},
|
|
IntPointerSlice: []*int{&integer},
|
|
StructSlice: []substructNoValidation{},
|
|
UniversalInterface: 1.2,
|
|
FloatMap: map[string]float32{
|
|
"foo": 1.23,
|
|
"bar": 232.323,
|
|
},
|
|
StructMap: mapNoValidationSub{
|
|
"foo": substructNoValidation{},
|
|
"bar": substructNoValidation{},
|
|
},
|
|
// StructPointerSlice []noValidationSub
|
|
// InterfaceSlice []testInterface
|
|
}
|
|
s.InlinedStruct.Integer = 1000
|
|
s.InlinedStruct.String = []string{"first", "second"}
|
|
s.IString = "substring"
|
|
s.IInt = 987654
|
|
return s
|
|
}
|
|
|
|
func TestValidateNoValidationValues(t *testing.T) {
|
|
origin := createNoValidationValues()
|
|
test := createNoValidationValues()
|
|
empty := structNoValidationValues{}
|
|
|
|
assert.Nil(t, validate(test))
|
|
assert.Nil(t, validate(&test))
|
|
assert.Nil(t, validate(empty))
|
|
assert.Nil(t, validate(&empty))
|
|
|
|
assert.Equal(t, origin, test)
|
|
}
|
|
|
|
type structNoValidationPointer struct {
|
|
substructNoValidation
|
|
|
|
Boolean bool
|
|
|
|
Uinteger *uint
|
|
Integer *int
|
|
Integer8 *int8
|
|
Integer16 *int16
|
|
Integer32 *int32
|
|
Integer64 *int64
|
|
Uinteger8 *uint8
|
|
Uinteger16 *uint16
|
|
Uinteger32 *uint32
|
|
Uinteger64 *uint64
|
|
|
|
Float32 *float32
|
|
Float64 *float64
|
|
|
|
String *string
|
|
|
|
Date *time.Time
|
|
|
|
Struct *substructNoValidation
|
|
|
|
IntSlice *[]int
|
|
IntPointerSlice *[]*int
|
|
StructPointerSlice *[]*substructNoValidation
|
|
StructSlice *[]substructNoValidation
|
|
InterfaceSlice *[]testInterface
|
|
|
|
FloatMap *map[string]float32
|
|
StructMap *mapNoValidationSub
|
|
}
|
|
|
|
func TestValidateNoValidationPointers(t *testing.T) {
|
|
//origin := createNoValidation_values()
|
|
//test := createNoValidation_values()
|
|
empty := structNoValidationPointer{}
|
|
|
|
//assert.Nil(t, validate(test))
|
|
//assert.Nil(t, validate(&test))
|
|
assert.Nil(t, validate(empty))
|
|
assert.Nil(t, validate(&empty))
|
|
|
|
//assert.Equal(t, origin, test)
|
|
}
|
|
|
|
type Object map[string]interface{}
|
|
|
|
func TestValidatePrimitives(t *testing.T) {
|
|
obj := Object{"foo": "bar", "bar": 1}
|
|
assert.NoError(t, validate(obj))
|
|
assert.NoError(t, validate(&obj))
|
|
assert.Equal(t, obj, Object{"foo": "bar", "bar": 1})
|
|
|
|
obj2 := []Object{{"foo": "bar", "bar": 1}, {"foo": "bar", "bar": 1}}
|
|
assert.NoError(t, validate(obj2))
|
|
assert.NoError(t, validate(&obj2))
|
|
|
|
nu := 10
|
|
assert.NoError(t, validate(nu))
|
|
assert.NoError(t, validate(&nu))
|
|
assert.Equal(t, nu, 10)
|
|
|
|
str := "value"
|
|
assert.NoError(t, validate(str))
|
|
assert.NoError(t, validate(&str))
|
|
assert.Equal(t, str, "value")
|
|
}
|
|
|
|
// structCustomValidation is a helper struct we use to check that
|
|
// custom validation can be registered on it.
|
|
// The `notone` binding directive is for custom validation and registered later.
|
|
type structCustomValidation struct {
|
|
Integer int `binding:"notone"`
|
|
}
|
|
|
|
// notOne is a custom validator meant to be used with `validator.v8` library.
|
|
// The method signature for `v9` is significantly different and this function
|
|
// would need to be changed for tests to pass after upgrade.
|
|
// See https://github.com/gin-gonic/gin/pull/1015.
|
|
func notOne(
|
|
v *validator.Validate, topStruct reflect.Value, currentStructOrField reflect.Value,
|
|
field reflect.Value, fieldType reflect.Type, fieldKind reflect.Kind, param string,
|
|
) bool {
|
|
if val, ok := field.Interface().(int); ok {
|
|
return val != 1
|
|
}
|
|
return false
|
|
}
|
|
|
|
func TestRegisterValidation(t *testing.T) {
|
|
// This validates that the function `notOne` matches
|
|
// the expected function signature by `defaultValidator`
|
|
// and by extension the validator library.
|
|
err := Validator.RegisterValidation("notone", notOne)
|
|
// Check that we can register custom validation without error
|
|
assert.Nil(t, err)
|
|
|
|
// Create an instance which will fail validation
|
|
withOne := structCustomValidation{Integer: 1}
|
|
errs := validate(withOne)
|
|
|
|
// Check that we got back non-nil errs
|
|
assert.NotNil(t, errs)
|
|
// Check that the error matches expactation
|
|
assert.Error(t, errs, "", "", "notone")
|
|
}
|