* path: use stack buffer in CleanPath to avoid allocs in common case
Sync from 8222db13db
* path: sync test code from httprouter
* path: update path_test.go to the latest code
Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
141 lines
2.9 KiB
Go
141 lines
2.9 KiB
Go
// Copyright 2013 Julien Schmidt. All rights reserved.
|
|
// Based on the path package, Copyright 2009 The Go Authors.
|
|
// Use of this source code is governed by a BSD-style license that can be found
|
|
// at https://github.com/julienschmidt/httprouter/blob/master/LICENSE
|
|
|
|
package gin
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type cleanPathTest struct {
|
|
path, result string
|
|
}
|
|
|
|
var cleanTests = []cleanPathTest{
|
|
// Already clean
|
|
{"/", "/"},
|
|
{"/abc", "/abc"},
|
|
{"/a/b/c", "/a/b/c"},
|
|
{"/abc/", "/abc/"},
|
|
{"/a/b/c/", "/a/b/c/"},
|
|
|
|
// missing root
|
|
{"", "/"},
|
|
{"a/", "/a/"},
|
|
{"abc", "/abc"},
|
|
{"abc/def", "/abc/def"},
|
|
{"a/b/c", "/a/b/c"},
|
|
|
|
// Remove doubled slash
|
|
{"//", "/"},
|
|
{"/abc//", "/abc/"},
|
|
{"/abc/def//", "/abc/def/"},
|
|
{"/a/b/c//", "/a/b/c/"},
|
|
{"/abc//def//ghi", "/abc/def/ghi"},
|
|
{"//abc", "/abc"},
|
|
{"///abc", "/abc"},
|
|
{"//abc//", "/abc/"},
|
|
|
|
// Remove . elements
|
|
{".", "/"},
|
|
{"./", "/"},
|
|
{"/abc/./def", "/abc/def"},
|
|
{"/./abc/def", "/abc/def"},
|
|
{"/abc/.", "/abc/"},
|
|
|
|
// Remove .. elements
|
|
{"..", "/"},
|
|
{"../", "/"},
|
|
{"../../", "/"},
|
|
{"../..", "/"},
|
|
{"../../abc", "/abc"},
|
|
{"/abc/def/ghi/../jkl", "/abc/def/jkl"},
|
|
{"/abc/def/../ghi/../jkl", "/abc/jkl"},
|
|
{"/abc/def/..", "/abc"},
|
|
{"/abc/def/../..", "/"},
|
|
{"/abc/def/../../..", "/"},
|
|
{"/abc/def/../../..", "/"},
|
|
{"/abc/def/../../../ghi/jkl/../../../mno", "/mno"},
|
|
|
|
// Combinations
|
|
{"abc/./../def", "/def"},
|
|
{"abc//./../def", "/def"},
|
|
{"abc/../../././../def", "/def"},
|
|
}
|
|
|
|
func TestPathClean(t *testing.T) {
|
|
for _, test := range cleanTests {
|
|
assert.Equal(t, test.result, cleanPath(test.path))
|
|
assert.Equal(t, test.result, cleanPath(test.result))
|
|
}
|
|
}
|
|
|
|
func TestPathCleanMallocs(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping malloc count in short mode")
|
|
}
|
|
|
|
for _, test := range cleanTests {
|
|
allocs := testing.AllocsPerRun(100, func() { cleanPath(test.result) })
|
|
assert.EqualValues(t, allocs, 0)
|
|
}
|
|
}
|
|
|
|
func BenchmarkPathClean(b *testing.B) {
|
|
b.ReportAllocs()
|
|
|
|
for i := 0; i < b.N; i++ {
|
|
for _, test := range cleanTests {
|
|
cleanPath(test.path)
|
|
}
|
|
}
|
|
}
|
|
|
|
func genLongPaths() (testPaths []cleanPathTest) {
|
|
for i := 1; i <= 1234; i++ {
|
|
ss := strings.Repeat("a", i)
|
|
|
|
correctPath := "/" + ss
|
|
testPaths = append(testPaths, cleanPathTest{
|
|
path: correctPath,
|
|
result: correctPath,
|
|
}, cleanPathTest{
|
|
path: ss,
|
|
result: correctPath,
|
|
}, cleanPathTest{
|
|
path: "//" + ss,
|
|
result: correctPath,
|
|
}, cleanPathTest{
|
|
path: "/" + ss + "/b/..",
|
|
result: correctPath,
|
|
})
|
|
}
|
|
return
|
|
}
|
|
|
|
func TestPathCleanLong(t *testing.T) {
|
|
cleanTests := genLongPaths()
|
|
|
|
for _, test := range cleanTests {
|
|
assert.Equal(t, test.result, cleanPath(test.path))
|
|
assert.Equal(t, test.result, cleanPath(test.result))
|
|
}
|
|
}
|
|
|
|
func BenchmarkPathCleanLong(b *testing.B) {
|
|
cleanTests := genLongPaths()
|
|
b.ResetTimer()
|
|
b.ReportAllocs()
|
|
|
|
for i := 0; i < b.N; i++ {
|
|
for _, test := range cleanTests {
|
|
cleanPath(test.path)
|
|
}
|
|
}
|
|
}
|