vinchent/go-by-test
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

***roman: add convert to arabic, the real one

Browse Source
This commit is contained in:
vinchent 2024-09-22 21:36:03 +02:00
parent 715ea6477a
commit 52825e49b3
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
roman/roman.go
View File

@ -37,5 +37,13 @@ func ConvertToRoman(arabic int) string {
} }
func ConvertToArabic(roman string) int { func ConvertToArabic(roman string) int {
return 1 var converted int
for _, numeral := range allRomanNumerals {
for strings.HasPrefix(roman, numeral.Symbol) {
converted += numeral.Value
// roman = roman[len(numeral.Symbol):]
roman = strings.TrimPrefix(roman, numeral.Symbol)
}
}
return converted
} }

2
roman/roman_test.go
View File

@ -54,7 +54,7 @@ func TestRomanNemerals(t *testing.T) {
} }
func TestConvertingToArabic(t *testing.T) { func TestConvertingToArabic(t *testing.T) {
for _, test := range cases[:1] { for _, test := range cases {
t.Run(fmt.Sprintf("%q gets converted to %d", test.Roman, test.Arabic), func(t *testing.T) { t.Run(fmt.Sprintf("%q gets converted to %d", test.Roman, test.Arabic), func(t *testing.T) {
got := ConvertToArabic(test.Roman) got := ConvertToArabic(test.Roman)
want := test.Arabic want := test.Arabic