From ce3076047a747f3a628f31f444bd074fbd3ef41f Mon Sep 17 00:00:00 2001 From: Muyao CHEN Date: Sat, 12 Oct 2024 17:09:03 +0200 Subject: [PATCH] feat: add t.Helper to request helper --- internal/pkg/middleware/requestid_test.go | 3 ++- internal/pkg/test/request.go | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/pkg/middleware/requestid_test.go b/internal/pkg/middleware/requestid_test.go index 0bee0a6..29a0fd6 100644 --- a/internal/pkg/middleware/requestid_test.go +++ b/internal/pkg/middleware/requestid_test.go @@ -50,6 +50,7 @@ func TestRequestID(t *testing.T) { // Test with Request ID _ = test.PerformRequest( + t, r, "GET", "/example?a=100", @@ -58,7 +59,7 @@ func TestRequestID(t *testing.T) { ) assert.Equal(t, "123", got) - res := test.PerformRequest(r, "GET", "/example?a=100", nil) + res := test.PerformRequest(t, r, "GET", "/example?a=100", nil) assert.NotEqual(t, "", got) assert.NoError(t, uuid.Validate(got)) assert.Equal(t, res.Header()[XRequestID][0], got) diff --git a/internal/pkg/test/request.go b/internal/pkg/test/request.go index b7bc866..75bad4b 100644 --- a/internal/pkg/test/request.go +++ b/internal/pkg/test/request.go @@ -4,6 +4,7 @@ import ( "io" "net/http" "net/http/httptest" + "testing" ) type Header struct { @@ -12,11 +13,13 @@ type Header struct { } func PerformRequest( + t testing.TB, r http.Handler, method, path string, body io.Reader, headers ...Header, ) *httptest.ResponseRecorder { + t.Helper() req := httptest.NewRequest(method, path, body) for _, h := range headers { req.Header.Add(h.Key, h.Value)