vinchent/gin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "fix(uri): query binding bug (#3236)" (#3899)

Browse Source 
This reverts commit 8790d08909.
This commit is contained in:
Bo-Yi Wu 2024-03-22 10:01:27 +08:00 committed by GitHub
parent 8790d08909
commit d4e4136488
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
binding/query.go
View File

@ -12,9 +12,9 @@ func (queryBinding) Name() string {
return "query"
}
func (q queryBinding) Bind(req *http.Request, obj any) error {
func (queryBinding) Bind(req *http.Request, obj any) error {
values := req.URL.Query()
if err := mapFormByTag(obj, values, q.Name()); err != nil {
if err := mapForm(obj, values); err != nil {
return err
}
return validate(obj)

23
binding/query_test.go
View File

@ -1,23 +0,0 @@
package binding
import (
"net/http"
"net/url"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestQueryBinding(t *testing.T) {
var s struct {
Foo string `query:"foo"`
}
request := &http.Request{URL: &url.URL{RawQuery: "foo=BAR"}}
err := queryBinding{}.Bind(request, &s)
require.NoError(t, err)
assert.Equal(t, "BAR", s.Foo)
}